add loading wheel, shoutouts #507
Conversation
|
[diff-counting] Significant lines: 46. |
|
Format check is failing. Run the formatter with |
|
Please include the notion ticket associated with the PR. That makes it easier for the reviewer (and future readers of the repo) to navigate back to and see the scope of the task you're working on + context. |
|
I like these changes! The Notion ticket specifies to fix this loading issue for the Admin side, not the member side (but these changes are much appreciated and we should still keep them). Can you also add the loading wheel to the admin view? |
| </Button.Group> | ||
| </Form.Group> | ||
| </Form> | ||
| <div className={styles.shoutoutsListContainer}> |
There was a problem hiding this comment.
Can you instead wrap <div className={styles.shoutoutsListContainer}></div> with the ternary with Loader? That way we can see a least some part of the page before everything loads in.
Ticket: "Shoutouts - Fix How Shoutouts Are Loaded In on Admin View"
Notion: https://www.notion.so/cornelldti/Idol-FA23-08f1aac52a364b1dad8cde77ebc1c027?p=c402189001014a1798a22db9286d4566&pm=s
implemented Loader from Semantic UI into "Shoutouts" - Previously, users were presented with empty space while waiting for shoutouts to load, leading to confusion regarding the application's state. The incorporation of a loading indicator serves to improve the user experience by providing real-time feedback and a more intuitive interaction.