Website: Remove width constraint on the image carousel #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[diff-counting] Significant lines: 2. |
andrew032011
requested review from
oscarwang20
and removed request for
oscarwang20
andrew032011
changed the title
oscarwang20
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The image carousel wasn't stretching to the full viewport width after stretching the screen long enough.
Remove the width constraint to allow for the carousel to take up the entire viewport width.
Before:
After:
Notion/Figma Link
https://www.notion.so/Carousel-Hero-Component-0-5-sprints-ab360524d0c541f4aedcba75b55f29de
Test Plan
Notes
Breaking Changes