Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev Portfolio: Make opened PR's Optional for TPMs #633

Merged
merged 1 commit into from
Sep 22, 2024

Conversation

andrew032011
Copy link
Collaborator

@andrew032011 andrew032011 commented Sep 21, 2024

Summary

Make opened PR's Optional for TPMs (policy change now only requires 2/5 PR's, so TPM's will decide when they want to submit PR's)

Notion/Figma Link

https://www.notion.so/Dev-Portfolio-Make-opened-PR-s-Optional-for-TPMs-1080ad723ce1801c88b3de2b69cfbef1?pvs=4

Test Plan

Manually submitted a TPM portfolio without open PRs.
Tried manually submitting a Dev portfolio without open PR's and it was not allowed.

TPM view:
Screenshot 2024-09-22 at 1 02 46 AM

Dev view:
Screenshot 2024-09-22 at 12 55 17 AM

Notes

Breaking Changes

@andrew032011 andrew032011 requested a review from a team as a code owner September 21, 2024 22:32
@dti-github-bot
Copy link
Member

dti-github-bot commented Sep 21, 2024

[diff-counting] Significant lines: 5.

@andrew032011 andrew032011 force-pushed the axc/make_opened_prs_optional_tpms branch from e9dbeec to 095c935 Compare September 21, 2024 22:42
Copy link
Contributor

@cchrischen cchrischen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@andrew032011 andrew032011 merged commit 04d813a into main Sep 22, 2024
17 checks passed
@andrew032011 andrew032011 deleted the axc/make_opened_prs_optional_tpms branch September 22, 2024 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants