New DTI Website: Remove Fading Transition for Photos in Slideshow #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[diff-counting] Significant lines: 4. |
andrew032011
force-pushed
the
axc/remove_fading_transition_slideshow
branch
from
10d4519
to
1d5f476
Compare
JasonMun7
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I forget whether we added the fading transition for flair or if it was actually part of the design. Frankly I think it looks borderline buggy, and I don’t like how the header and the slide aren’t perfectly fading in alignment (even if we fixed that, I don’t know if I’d like it).
Let's try switching the slideshow component to switch between photos without the fading transition
Notion/Figma Link
Test Plan
Before:
Screen.Recording.2024-09-24.at.8.00.25.PM.mov
After:
Screen.Recording.2024-09-24.at.7.59.34.PM.mov
Notes
Breaking Changes