Filter Admin Only Cards for Home Page #651
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We previously were only filtering navigation cards on the "Forms" tab, but not the home page. This is because we had two navigation card components,
NavCard
andNavigationCard
, the first of which did not contain logic to filter against the "adminOnly" flag. We should allowadminOnly
to be used on the homepage if we want to gate something through a feature flag.Also, update the Homepage to use
NavigationCard
and deleteNavCard
. This consequently also fixes an alignment issue on the homepage too.Notion/Figma Link
Test Plan
Verification steps:
Before:
After:
Notes
Breaking Changes