TEC: Don't Delete Image when Rejecting TEC Requests #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[diff-counting] Significant lines: 1. |
patriciaahuang
approved these changes
Oct 8, 2024
andrew032011
deleted the
axc/dont_remove_image_when_rejecting_tec_request
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Kevin found that images for rejected TEC requests weren't being saved. Looks like we used to remove the image upon rejecting a TEC attendance request since we used to delete the TEC attendance altogether when it was rejected, instead of saving a record.
Looks like there aren't any rejected requests yet so this hasn't been a problem, but we'll want these images when we start making them available on the admin view.
Notion/Figma Link
https://www.notion.so/TEC-Don-t-Delete-Image-When-Rejecting-TEC-Requests-1180ad723ce18075ad73c5e6c2478ccc?pvs=4
Test Plan
Notes
Breaking Changes