Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Router.pathVar #212

Closed
wants to merge 1 commit into from
Closed

Add Router.pathVar #212

wants to merge 1 commit into from

Conversation

fdietze
Copy link
Collaborator

@fdietze fdietze commented Jul 3, 2022

No description provided.

@cornerman
Copy link
Owner

I am hesitant to add alternative implementations for variables everywhere. What speaks against just converting the Router.pathSubject to a variable. It works like this: Var.combine(Rx.observableSync(subject), RxWriter.observer(subject)). Is that not enough?

@fdietze
Copy link
Collaborator Author

fdietze commented Jul 4, 2022

True. And in this case it's enough (maybe with a conversion helper for BehaviorSubject -> Var).

It doesn't work for the general case, though (as mentioned in #213 (comment)).

@fdietze fdietze closed this Jul 9, 2022
@cornerman
Copy link
Owner

We should a simpler converter from subject to var though - even if it is not correct for all cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants