Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge forward prototype thijstriemstra #114

Closed
Closed
Changes from all commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
07bf51c
adjustments for prototype
corrados Dec 20, 2021
d3badc8
update settings based on https://github.com/corrados/edrumulus/discus…
corrados Dec 21, 2021
973dc96
update comments for config
thijstriemstra Dec 29, 2021
877ac65
Merge pull request #27 from thijstriemstra/patch-1
corrados Dec 30, 2021
d51bf88
merge forward
thijstriemstra Jan 3, 2022
f3b9744
fix pad type for 4
thijstriemstra Jan 4, 2022
409e76e
Merge pull request #32 from thijstriemstra/thijstriemstra_prototype
corrados Jan 4, 2022
21120f2
define board led pin elsewhere
thijstriemstra Jan 6, 2022
efd7cc7
update parameters
thijstriemstra Jan 6, 2022
780c26a
Merge pull request #34 from thijstriemstra/thijstriemstra_prototype
corrados Jan 6, 2022
fa71e45
Merge branch 'main' into thijstriemstra_prototype
thijstriemstra Jan 6, 2022
57e1309
Merge branch 'main' into thijstriemstra_prototype
thijstriemstra Jan 7, 2022
9758509
Merge branch 'main' into thijstriemstra_prototype
thijstriemstra Jan 8, 2022
1b37424
Merge pull request #37 from thijstriemstra/thijstriemstra_prototype
corrados Jan 8, 2022
ba8b2d6
Merge branch 'main' into thijstriemstra_prototype
thijstriemstra Jan 9, 2022
966f816
Merge branch 'main' into thijstriemstra_prototype
thijstriemstra Jan 9, 2022
7aa57d2
Merge branch 'main' into thijstriemstra_prototype
thijstriemstra Jan 9, 2022
172ada2
update pad settings
thijstriemstra Jan 9, 2022
9029398
Merge pull request #42 from thijstriemstra/thijstriemstra_prototype
corrados Jan 9, 2022
f95914e
Merge branch 'main' into thijstriemstra_prototype
thijstriemstra Jan 11, 2022
0382e85
Merge branch 'main' into thijstriemstra_prototype
thijstriemstra Jan 11, 2022
32ebb92
Merge branch 'main' into thijstriemstra_prototype
thijstriemstra Jan 12, 2022
3730158
update pad params
thijstriemstra Jan 12, 2022
e008ecc
Merge pull request #43 from thijstriemstra/thijstriemstra_prototype
corrados Jan 12, 2022
b1cc22b
Merge branch 'main' into thijstriemstra_prototype
thijstriemstra Jan 12, 2022
83ed415
Merge branch 'main' into thijstriemstra_prototype
thijstriemstra Jan 17, 2022
955d4d5
Merge pull request #45 from thijstriemstra/thijstriemstra_prototype
corrados Jan 17, 2022
3159408
Merge branch 'main' into thijstriemstra_prototype
thijstriemstra Jan 19, 2022
b1ebda1
Merge branch 'main' into thijstriemstra_prototype
thijstriemstra Jan 19, 2022
7fecd64
Merge branch 'main' into thijstriemstra_prototype
thijstriemstra Jan 27, 2022
49229d1
Merge branch 'main' into thijstriemstra_prototype
thijstriemstra Jan 27, 2022
cd5c2ca
Merge branch 'main' into thijstriemstra_prototype
thijstriemstra Jul 4, 2022
aa02d1d
merge forward
thijstriemstra Nov 8, 2023
582f005
Merge branch 'main' into thijstriemstra_prototype
thijstriemstra Nov 8, 2023
d33f19a
Merge branch 'main' into thijstriemstra_prototype
thijstriemstra Nov 8, 2023
19a2a56
Merge branch 'main' into thijstriemstra_prototype
thijstriemstra Nov 11, 2023
c7596e3
Merge remote-tracking branch 'upstream/main' into thijstriemstra_prot…
thijstriemstra Nov 11, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 57 additions & 11 deletions edrumulus.ino
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ static int analog_pins_rimshot4[] = { 35, -1, 26, -1, 14,

// if you want to use less number of pads, simply adjust number_pads4 value
//const int number_pads4 = sizeof ( analog_pins4 ) / sizeof ( int ); // example: use all inputs defined in analog_pins4
const int number_pads4 = 8; // example: do not use tom3 and shrink number of pads from 9 to 8
const int number_pads4 = 6;
//const int number_pads4 = 1; // example: just one single pad


Expand Down Expand Up @@ -104,16 +104,19 @@ void setup()
void preset_settings()
{
// default MIDI note assignments
edrumulus.set_midi_notes ( 0, 38, 40 ); // snare
edrumulus.set_midi_notes ( 1, 36, 36 ); // kick
edrumulus.set_midi_notes ( hihat_pad_idx, 22 /*42*/, 22 );
edrumulus.set_midi_notes_open ( hihat_pad_idx, 26 /*46*/, 26 );
edrumulus.set_midi_notes ( hihatctrl_pad_idx, 44, 44 ); // Hi-Hat pedal hit
edrumulus.set_midi_notes ( 4, 49, 55 ); // crash
edrumulus.set_midi_notes ( 5, 48, 50 ); // tom 1
edrumulus.set_midi_notes ( 6, 51, 53 /*59*/ ); // ride (edge: 59, bell: 53)
edrumulus.set_midi_notes ( 7, 45, 47 ); // tom 2
edrumulus.set_midi_notes ( 8, 43, 58 ); // tom 3
edrumulus.set_midi_notes ( 0, 38, 40 ); // snare
edrumulus.set_midi_notes ( 1, 36, 36 ); // kick
// not sure what difference between set_midi_notes and set_midi_notes_open is.
// only set_midi_notes_open seems to work?
//edrumulus.set_midi_notes ( hihat_pad_idx, 22, 26 );
edrumulus.set_midi_notes_open ( hihat_pad_idx, 28, 32 );
edrumulus.set_midi_notes ( hihatctrl_pad_idx, 44, 44 ); // Hi-Hat pedal hit
edrumulus.set_midi_ctrl_ch ( hihatctrl_pad_idx, 4 ); // Hi-Hat control
edrumulus.set_midi_notes ( 4, 49, 49 ); // tom 1
edrumulus.set_midi_notes ( 5, 48, 48 ); // tom 2
edrumulus.set_midi_notes ( 6, 51, 53 ); // x
edrumulus.set_midi_notes ( 7, 45, 47 ); // x
//edrumulus.set_midi_notes ( 8, 43, 58 ); // x

// default drum kit setup
edrumulus.set_pad_type ( 0, Edrumulus::PD8 ); // snare
Expand All @@ -125,6 +128,49 @@ void preset_settings()
edrumulus.set_pad_type ( 6, Edrumulus::CY8 ); // ride
edrumulus.set_pad_type ( 7, Edrumulus::TP80 ); // tom 2
edrumulus.set_pad_type ( 8, Edrumulus::TP80 ); // tom 3

// thijstriemstra prototype setup configuration...

// SNARE (Drum-tec Diabolo 12 inch)
edrumulus.set_pad_type ( 0, Edrumulus::DIABOLO12 );
// disable for now
//edrumulus.set_pos_sense_is_used ( 0, false );
// disable rim for now, see
// https://github.com/corrados/edrumulus/discussions/30#discussioncomment-1908586
//edrumulus.set_rim_shot_is_used ( 0, false );
//edrumulus.set_rim_shot_treshold ( 0, 25 );
//edrumulus.set_velocity_threshold ( 0, 9 );
//edrumulus.set_pos_sense_is_used ( 0, true );
//edrumulus.set_pos_threshold ( 0, 4 );
//edrumulus.set_pos_sensitivity ( 0, 17 );

// KICK (Roland KD-120BK)
// see https://github.com/corrados/edrumulus/discussions/29
edrumulus.set_pad_type ( 1, Edrumulus::KD120 );
// less dynamic on kick (similar to other drum modules)
//edrumulus.set_curve ( 1, Edrumulus::LOG2 );
//edrumulus.set_velocity_threshold ( 1, 12 ); // default is 8
//edrumulus.set_velocity_sensitivity ( 1, 16 ); // default is 9

// HI-HAT (using rim switch, Roland CY-5)
edrumulus.set_pad_type ( hihat_pad_idx, Edrumulus::CY5 );
//edrumulus.set_rim_shot_is_used ( hihat_pad_idx, true );
//edrumulus.set_rim_shot_treshold ( hihat_pad_idx, 31 );
//edrumulus.set_velocity_threshold ( hihat_pad_idx, 17 );
//edrumulus.set_velocity_sensitivity ( hihat_pad_idx, 21 );

// HI-HAT CTRL (FD-8)
edrumulus.set_pad_type ( hihatctrl_pad_idx, Edrumulus::FD8 );

// TOM1 (Roland PD-5)
edrumulus.set_pad_type ( 4, Edrumulus::PD5 );
//edrumulus.set_velocity_threshold ( 4, 15 );
//edrumulus.set_velocity_sensitivity ( 4, 12 );

// TOM2 (Roland PD-5)
edrumulus.set_pad_type ( 5, Edrumulus::PD5 );
//edrumulus.set_velocity_threshold ( 5, 15 );
//edrumulus.set_velocity_sensitivity ( 5, 12 );
}


Expand Down