Legacy CMake: Respect CMAKE_<XYZ>_OUTPUT_DIRECTORY
#522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschwe
force-pushed
the
jschwender/legacy_partially_respect_output_dir
branch
6 times, most recently
from
a3407b7
to
77a03a4
Compare
Make a best effort with old CMake version to respect output directories. We can't know which properties the user might set or change **after** the crates are imported, but we can respect the `CMAKE_<XYZ>` variables which are set **before** the crates are imported.
Create the main CMake targets earlier, so we can set target properties on them early in the generator, so we can use them later on during configuration.
jschwe
force-pushed
the
jschwender/legacy_partially_respect_output_dir
branch
from
1339945
to
743f8d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make a best effort with old CMake versions to respect output directories. We can't know which properties the user might set or change after the crates are imported, but we can respect the
CMAKE_<XYZ>variables which are set before the crates are imported.