Inventory Management #163
Merged
Inventory Management #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot exposed to lua yet. Remove code for putting away and retrieving offhand when proning/crouching/climbing. This would probably have been better done before midnight, will review.
Causeless
previously approved these changes
Dec 7, 2024
Contributor
Causeless
left a comment
Causeless
left a comment
There was a problem hiding this comment.
Nice! Should make things a bit less annoying
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Causeless
approved these changes
Dec 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes code to put away offhand automatically, and code to take out offhand automatically, both of which are typically aggravating in stressful situations where they may be triggered in error, such as trying to scurry in cramped halls while holding a shield.
Also adds code to ensure an offhand is discarded to the same side of the inventory as the onhand.
This is prelude to a minor inventory overhaul aimed at keeping order over time so that your inventory doesn't shuffle unless you're trying to shuffle it, but I don't know how exactly that'd work yet.