Skip to content

Fix embarrassing SupportedGameVersion crash #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Causeless merged 1 commit into from
Dec 7, 2024
Merged

Fix embarrassing SupportedGameVersion crash #164

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions Source/System/DataModule.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -492,26 +492,30 @@ bool DataModule::AddToTypeMap(Entity* entityToAdd) {
}

void DataModule::CheckSupportedGameVersion() const {
static const std::string contactAuthor = "Please contact the mod author or ask for help in the CCCP discord server.";

RTEAssert(m_SupportedGameVersion, m_FileName + " does not specify a supported Cortex Command version, so it is not compatible with this version of Cortex Command (" + c_GameVersion.str() + ")\n\n" + contactAuthor);

if (!m_SupportedGameVersion) {
return;
}

if (*m_SupportedGameVersion == c_GameVersion) {
return;
}

static const std::string contactAuthor = "Please contact the mod author or ask for help in the CCCP discord server.";

RTEAssert(m_SupportedGameVersion, m_FileName + " does not specify a supported Cortex Command version, so it is not compatible with this version of Cortex Command (" + c_GameVersion.str() + ").\n\n" + contactAuthor);

bool modulePrereleaseVersionMismatch = !m_SupportedGameVersion->prerelease().empty();
bool moduleBuildVersionMismatch = !m_SupportedGameVersion->build().empty();
RTEAssert(!modulePrereleaseVersionMismatch && !moduleBuildVersionMismatch, m_FileName + " was developed for pre-release build of Cortex Command v" + m_SupportedGameVersion->str() + ", this game version (v" + c_GameVersion.str() + ") is incompatible.\n\nMods developed on a pre-release must match the game version exactly.\n" + contactAuthor);
RTEAssert(!modulePrereleaseVersionMismatch && !moduleBuildVersionMismatch, m_FileName + " was developed for pre-release build of Cortex Command v" + m_SupportedGameVersion->str() + ", so this game version (v" + c_GameVersion.str() + ") may not support it.\n\n" + contactAuthor);

bool gamePrereleaseVersionMismatch = !c_GameVersion.prerelease().empty();
bool gameBuildVersionMismatch = !c_GameVersion.build().empty();
RTEAssert(!gamePrereleaseVersionMismatch && !gameBuildVersionMismatch, m_FileName + " was developed for Cortex Command v" + m_SupportedGameVersion->str() + ", this pre-release version of the game (v" + c_GameVersion.str() + ") may not support it.\n\nMods must match the game version exactly to use pre-release builds.\n" + contactAuthor);
RTEAssert(!gamePrereleaseVersionMismatch && !gameBuildVersionMismatch, m_FileName + " was developed for Cortex Command v" + m_SupportedGameVersion->str() + ", so this pre-release version of the game (v" + c_GameVersion.str() + ") may not support it.\n\n" + contactAuthor);

// Game engine is the same major version as the Module
bool majorVersionMatch = c_GameVersion.major() == m_SupportedGameVersion->major();
// Game engine is at least the minor version the Module requires (allow patch mismatch)
bool minorVersionInRange = m_SupportedGameVersion->inc_minor() <= c_GameVersion.inc_minor();

RTEAssert(majorVersionMatch && minorVersionInRange, m_FileName + " was developed for Cortex Command v" + m_SupportedGameVersion->str() + ", so this version of Cortex Command (v" + c_GameVersion.str() + ") may not support it.\n" + contactAuthor);
RTEAssert(majorVersionMatch && minorVersionInRange, m_FileName + " was developed for Cortex Command v" + m_SupportedGameVersion->str() + ", so this version of Cortex Command (v" + c_GameVersion.str() + ") may not support it.\n\n" + contactAuthor);
}
Loading