Bump minSdk #206
Merged
Bump minSdk #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
What's the reason why you bumped to 24 and not 23? |
I was thinking of 23, but I know that the new projects are created with the 24 minSdk version, and I decided to use it. But if you think it is not good, I can change to 23, np. |
|
Yup I'll try to stick to https://twitter.com/minsdkversion So 23 is probably to be preferred here |
|
Updated to 23. |
cortinico
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Description
While testing composeBom, it was noticed that compose ui test fails even on master. The problem is that minSdk is low
📄 Motivation and Context
It fixes the failed compose ui test
🧪 How Has This Been Tested?
The project builds and runs successfully.
compose ui test runs successfully
📷 Screenshots (if appropriate)
Provided
📦 Types of changes
✅ Checklist