test: verify zbus::Error to AppError conversion#82
Conversation
This commit introduces a new `tests` module in `src/app/error.rs` to verify the `From<zbus::Error>` implementation for `AppError`. It includes: - A helper function `create_method_error` to construct `zbus::Error::MethodError` with a dummy D-Bus message. - Test cases for all mapped `net.reactivated.Fprint.Error.*` strings. - Test cases for unknown errors and non-MethodError variants to ensure correct fallback to `AppError::Unknown`. This improves test coverage for critical error handling logic.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Added unit tests to
src/app/error.rsto verify the conversion fromzbus::ErrortoAppError.zbus::Errorvariants.AppErrorderivesPartialEqallowing direct assertions.zbus::Error::MethodErrorcorrectly for the usedzbusversion (5.13.2).PR created automatically by Jules for task 3125849291498438236 started by @jotuel