colspanned columns should inherit tag #202
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Colspanned columns need to inherit the tag of the original column. Otherwise, in a header row, this leaves you with a bunch of `th` tags separated by `tds` tags (since the default is to treat an empty tag as `td` per https://github.com/cosmocode/edittable/blob/09298eaff7a6ebcb9892511587fac055380c5653/action/editor.php#L222) When the array is parsed by build_table, this means the table is actually malformed per DokuWiki syntax and what should be a `^` ends up being a `|`; this later generates bad or unexpected HTML - `th` elements end up in `tbody` instead of `thead`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Colspanned columns need to inherit the tag of the original column. Otherwise, in a header row, this leaves you with a bunch of
thtags separated bytdstags (since the default is to treat an empty tag astdperedittable/action/editor.php
Line 222 in 09298ea
When the array is parsed by build_table, this means the table is actually malformed per DokuWiki syntax and what should be a
^ends up being a|; this later generates bad or unexpected HTML -thelements end up intbodyinstead ofthead.