Skip to content

Conversation

@mmsqe
Copy link
Contributor

@mmsqe mmsqe commented Oct 10, 2025

add Ledger app name

Description

change to allow switch Cosmos and Ethereum app when using different cointype like cosmos/evm#690

@aljo242
Copy link
Contributor

aljo242 commented Oct 13, 2025

Can you document how a user could make the change that this is enabling?

@aljo242 aljo242 enabled auto-merge October 21, 2025 18:26
@aljo242 aljo242 added this pull request to the merge queue Oct 21, 2025
@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.83%. Comparing base (17f9c3b) to head (2c786ed).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crypto/ledger/ledger_secp256k1.go 33.33% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #25435      +/-   ##
==========================================
- Coverage   52.83%   52.83%   -0.01%     
==========================================
  Files         798      798              
  Lines       64953    64955       +2     
==========================================
- Hits        34317    34316       -1     
- Misses      30636    30639       +3     
Files with missing lines Coverage Δ
crypto/ledger/ledger_secp256k1.go 62.03% <33.33%> (-0.68%) ⬇️

... and 1 file with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Merged via the queue into cosmos:main with commit 9c4af5a Oct 21, 2025
39 of 40 checks passed
warpbuild-benchmark-bot bot added a commit to WarpBuilds/cosmos-sdk that referenced this pull request Oct 21, 2025
mmsqe added a commit to mmsqe/cosmos-sdk that referenced this pull request Oct 22, 2025
Co-authored-by: Alex | Cosmos Labs <alex@cosmoslabs.io>
aljo242 added a commit that referenced this pull request Oct 22, 2025
… (#25484)

Co-authored-by: Alex | Cosmos Labs <alex@cosmoslabs.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants