Skip to content

fix(rpc): correct block number conversion in eth_getProof #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+2 −1
Open

fix(rpc): correct block number conversion in eth_getProof #742

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
49b762f
fix(rpc): correct block number conversion in eth_getProof
Cordtus Oct 20, 2025
628fb50
chore: update changelog for eth_getProof fix
Cordtus Oct 20, 2025
7add4c8
Merge branch 'main' into fix/rpc-eth-getproof-height-bug
Cordtus Oct 23, 2025
2035076
Merge branch 'main' into fix/rpc-eth-getproof-height-bug
Cordtus Oct 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

### BUG FIXES

- [\#742](https://github.com/cosmos/evm/pull/742) Fix eth_getProof block number conversion for special block parameters (latest, pending, earliest).
- [\#471](https://github.com/cosmos/evm/pull/471) Notify new block for mempool in time
- [\#492](https://github.com/cosmos/evm/pull/492) Duplicate case switch to avoid empty execution block
- [\#509](https://github.com/cosmos/evm/pull/509) Allow value with slashes when query token_pairs
Expand Down
2 changes: 1 addition & 1 deletion rpc/backend/account_info.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ func (b *Backend) GetProof(address common.Address, storageKeys []string, blockNr
return nil, err
}

height := int64(blockNum)
height := blockNum.Int64()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's refactor the Int64() function to be named AdjustedInt64() to clearly denote that it transforms 0's into 1's. Otherwise, PR looks good to me!


_, err = b.CometHeaderByNumber(blockNum)
if err != nil {
Expand Down
Loading