Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate MerklePathPrefix and Path #7193

Merged
merged 3 commits into from
Aug 26, 2024

Conversation

AdityaSripal
Copy link
Member

Description

Add validation for merkle path prefix and path. Add tests

We can maybe go even further with validation but this is a good start for now

closes: #6989


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

think this lgtm, left some minor nits

modules/core/23-commitment/types/v2/merkle.go Outdated Show resolved Hide resolved
modules/core/23-commitment/types/v2/merkle.go Outdated Show resolved Hide resolved
modules/core/23-commitment/types/v2/merkle.go Outdated Show resolved Hide resolved
modules/core/23-commitment/types/v2/merkle_test.go Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Aug 26, 2024

@crodriguezvega crodriguezvega merged commit 1c5e886 into feat/ibc-eureka Aug 26, 2024
66 checks passed
@crodriguezvega crodriguezvega deleted the aditya/validate-merkle branch August 26, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Decide on validation for merkle path prefix in MsgProvideCounterParty
3 participants