Skip to content

Make pallet-patcher version aware and add priority search mechanism#1

Open
Blast545 wants to merge 12 commits intomainfrom
blast545/smarter_pallet_patcher
Open

Make pallet-patcher version aware and add priority search mechanism#1
Blast545 wants to merge 12 commits intomainfrom
blast545/smarter_pallet_patcher

Conversation

@Blast545
Copy link
Collaborator

As the title says.

This is the list of the changes addressed in this PR:

-> Moved the logic to parse the dependencies available in a search path outside of the iteration loop. It should be easier to test if we move this one out of the compose loop.

-> Added a file with the logic required to solve the dependency specifiers in Rust. This was AI generated, we have to think which cases we want to handle there and how.

-> We are also saving the dependency version we have available. That way we can use different ones if needed be.

-> Added more verbose output to the scenario where a dependency wasn't found either in the workspace search path or the system installed path.

-> Added a priority system: We default to prefer anything available locally, then we fetch system installed crates, then we rely on cargo. I think we also need to change the way that cargo will treat those at a colcon level. Crates installed by the system will be treated as Immutable and crates installed in the workspace will be treated as patches. That way, if the user wants to make any modifications to those crates, cargo will pick it up correctly.

@Blast545 Blast545 requested a review from cottsay January 23, 2026 16:38
@Blast545
Copy link
Collaborator Author

Blast545 commented Feb 5, 2026

This seems to be working, the demo of this PR lies in this CI run:

https://github.com/Blast545/test_cargo_pulling_deps/actions/runs/21700214935/job/62578982853?pr=1

Check with the updated version of: Blast545/test_cargo_pulling_deps#1

@Blast545 Blast545 force-pushed the blast545/smarter_pallet_patcher branch 4 times, most recently from aefa0e2 to c93f0e1 Compare February 6, 2026 20:27
@Blast545
Copy link
Collaborator Author

Blast545 commented Feb 6, 2026

As of [c93f0e1] this PR works fully functional with colcon/colcon-cargo#69. I'll add a couple of commits related to discussions that I had with @cottsay and later split it in easier to review chunks.

Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
…optional deps

Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
@Blast545 Blast545 force-pushed the blast545/smarter_pallet_patcher branch from e0e8cde to 2b18496 Compare February 24, 2026 00:39
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
@Blast545 Blast545 force-pushed the blast545/smarter_pallet_patcher branch 2 times, most recently from 414341e to 161869d Compare February 24, 2026 01:52
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants