Make pallet-patcher version aware and add priority search mechanism#1
Open
Make pallet-patcher version aware and add priority search mechanism#1
Conversation
Collaborator
Author
|
This seems to be working, the demo of this PR lies in this CI run: https://github.com/Blast545/test_cargo_pulling_deps/actions/runs/21700214935/job/62578982853?pr=1 Check with the updated version of: Blast545/test_cargo_pulling_deps#1 |
cottsay
reviewed
Feb 6, 2026
aefa0e2 to
c93f0e1
Compare
Collaborator
Author
|
As of [c93f0e1] this PR works fully functional with colcon/colcon-cargo#69. I'll add a couple of commits related to discussions that I had with @cottsay and later split it in easier to review chunks. |
This was referenced Feb 9, 2026
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
…optional deps Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
e0e8cde to
2b18496
Compare
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
414341e to
161869d
Compare
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the title says.
This is the list of the changes addressed in this PR:
-> Moved the logic to parse the dependencies available in a search path outside of the iteration loop. It should be easier to test if we move this one out of the compose loop.
-> Added a file with the logic required to solve the dependency specifiers in Rust. This was AI generated, we have to think which cases we want to handle there and how.
-> We are also saving the dependency version we have available. That way we can use different ones if needed be.
-> Added more verbose output to the scenario where a dependency wasn't found either in the workspace search path or the system installed path.
-> Added a priority system: We default to prefer anything available locally, then we fetch system installed crates, then we rely on cargo. I think we also need to change the way that cargo will treat those at a colcon level. Crates installed by the system will be treated as Immutable and crates installed in the workspace will be treated as patches. That way, if the user wants to make any modifications to those crates, cargo will pick it up correctly.