Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing CBLLogSinks.h header in iOS framework #599

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Fix missing CBLLogSinks.h header in iOS framework #599

merged 1 commit into from
Feb 4, 2025
+1 −1

Conversation

pasin
Copy link
Contributor

@pasin pasin commented Feb 4, 2025

Set the target level of CBLLogSinks.h to public in the XCode Project.

@pasin
Fix missing CBLLogSinks.h header in iOS framework
4385ebd 
Set the target level of CBLLogSinks.h to public in the XCode Project.
@pasin pasin requested a review from velicuvlad February 4, 2025 18:42
@cbl-bot
Copy link

cbl-bot commented Feb 4, 2025

Code Coverage Results:

Branches Functions Instantiations Lines Regions
77.05 93.68 41.45 90.61 86.48

@pasin pasin requested review from bmeike and jianminzhao February 4, 2025 18:55
@pasin pasin merged commit 6c4dc09 into release/3.2 Feb 4, 2025
6 checks passed
@pasin pasin deleted the fix/missing_logsinks_header branch February 4, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianminzhao jianminzhao jianminzhao approved these changes

@velicuvlad velicuvlad Awaiting requested review from velicuvlad

@bmeike bmeike Awaiting requested review from bmeike

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pasin @cbl-bot @jianminzhao