-
Notifications
You must be signed in to change notification settings - Fork 39
DOC-13296 fixup gs downloads #979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked all the updated links and they are fine 👍
However I noticed a couple of unrelated issues with the markup of the page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the Community Edition and Enterprise Edition tabs are not working because of the anchors embedded within the tabbed interface blocks, e.g. at line 1581 (and throughout). Not sure if you want to do anything about this. I would remove the anchors within the tabbed interface blocks, and probably the anchors for each "Download link table" heading as well? They're repetitive, and I don't think any of these are needed because the headings already have anchors.
Secondly, in the output, each tabbed interface block is captioned "Example:" when you really want it to be captioned as a table. Again, not sure if you want to do anything about this. Could hide example captions for this page? Or just remove the "Download link table" headings, because again I'm not sure that they're needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@simon-dew I was doing the minimal to fix the reported issue, but I could look over this with Fortune later this week as a learning exercise, if you think that's appropriate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to +1 if you need a quick fix! I'll make a note of these issues and raise a ticket later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 — the updated links all work
Draft as missing info on 3 broken links (asked in #mobile-docs-related) though this fix could be merged in separately if needed.Preview building to https://preview.docs-test.couchbase.com/docs-couchbase-lite-DOC-13296-fixup-gs-downloads/couchbase-lite/current/c/gs-downloads.html
@RichardSmedley will need porting to 3.3 also.