Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MB-7960: XDCR on pipelined memcached binary protocol #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

MB-7960: XDCR on pipelined memcached binary protocol #1

wants to merge 1 commit into from

Conversation

xiejunyi
Copy link

Change-Id: I3c6acb885baed33bdcbeb4d2f5165d036146d080

MB-7960: XDCR on pipelined memcached binary protocol
e6552b8 
Change-Id: I3c6acb885baed33bdcbeb4d2f5165d036146d080
@xiejunyi
Copy link
Author

Please ignore, by mistake.

ns-codereview pushed a commit that referenced this pull request Apr 10, 2018
@ebenhaber
Change information collection to comply with GDPR
c7fa18c 
With Couchbase's new GDPR policies, we need to be very careful in
handling any person data we collect. We had a GDPR meeting this week
concerning phone home data, and we came to the following conclusions:

1) We should not collect Name/Email/Company Name, because we have
never actually used that information, and we don't want to have to
come up with a privacy statement and figure out how to safely handle
all the data.

2) We need some kind of privacy statement in the configuration page
relating to "Enable software update notifications in the web console."

To solve #1, I removed the "Register for Updates" section in the
configuration panel. To solve #2, I copied the toolip that currently
exists in the "Settings" panel to the "New Cluster / Configure" panel.

I also removed replication IP address from the XDCR information
included in PhoneHome, because that is potentially identifiable
information.

Change-Id: Id6e983a3cc9474852a5672b515aff88da66467c9
Reviewed-on: http://review.couchbase.org/92205
Tested-by: Eben Haber <eben@couchbase.com>
Well-Formed: Build Bot <build@couchbase.com>
Reviewed-by: Rob Ashcom <rob.ashcom@gmail.com>
Reviewed-by: Pavel Blagodov <stochmail@gmail.com>
ns-codereview pushed a commit that referenced this pull request Mar 21, 2019
@robashcom @pavel-blagodov
Chart builder style revision #1
9935a23 
Revise chart builder visual style:
- pill navigation for stat sections
- selectable filters for Data section
- consolidated vertical space
- made lists of stats + checkboxes into columns
- made dialog wider + max-height-500 (scrolling)

Change-Id: I37fe6e2150b076a73b8bd0a6cd356938b3f202d7
Reviewed-on: http://review.couchbase.org/106111
Reviewed-by: Rob Ashcom <rob.ashcom@gmail.com>
Reviewed-by: Pavel Blagodov <stochmail@gmail.com>
Tested-by: Pavel Blagodov <stochmail@gmail.com>
ns-codereview pushed a commit that referenced this pull request Mar 21, 2019
@pavel-blagodov
dashboard style revisions #1
799586b 
this changes the overall layout of the Overview page +
revises the scenario controls

Change-Id: I5673f942700d5f2736553c7b6c6c633a02daa799
Reviewed-on: http://review.couchbase.org/106293
Reviewed-by: Pavel Blagodov <stochmail@gmail.com>
Tested-by: Pavel Blagodov <stochmail@gmail.com>
ns-codereview pushed a commit that referenced this pull request Mar 21, 2019
@robashcom
Dashboard footer revision #1
13231aa 
Tightened layout
Renamed some styles
Made markup more semantic (like replacing <b> with <p>)

Change-Id: I32752217be24868ee9cec55c84099574f1a2a23d
Reviewed-on: http://review.couchbase.org/106587
Reviewed-by: Rob Ashcom <rob.ashcom@gmail.com>
Tested-by: Rob Ashcom <rob.ashcom@gmail.com>
ns-codereview pushed a commit that referenced this pull request Mar 25, 2019
@robashcom @pavel-blagodov
LDAP config dialog revision #1
d699f14 
- added help sidebar
- added placeholder text
- reordered some elements in the dialog
- added a new control for “Allow anonymous access”

TBD “Allow anonymous access” needs backend activation
TBD Validation of form field input is spotty
TBD Actual text for help needs revision

Change-Id: I48ce30f7c8878a0de4ac0f3fcf27fde7ecd51911
Reviewed-on: http://review.couchbase.org/106649
Tested-by: Rob Ashcom <rob.ashcom@gmail.com>
Reviewed-by: Pavel Blagodov <stochmail@gmail.com>
Tested-by: Pavel Blagodov <stochmail@gmail.com>
ns-codereview pushed a commit that referenced this pull request Mar 25, 2019
@robashcom @pavel-blagodov
Dashboard group controls revision #1
2de8a89 
- added styles for the row of disclosure, group name, save & delete controls
- changed the behavior of editing the group:
   - - focus on the group name shows save and delete icons
   - - blur or clicking save/delete hides the icons & blurs the name field
   - - typing in the name field extends the width of the field dynamically!!
- added styles for vertical spacing of the groups from one another
- added a new HTML template for specifically deleting groups
- formatted A LOT of code >> attributes should be indented 3 spaces

Change-Id: I43450db86b6a115192518508341c138cf0488ba9
Reviewed-on: http://review.couchbase.org/106669
Reviewed-by: Pavel Blagodov <stochmail@gmail.com>
Tested-by: Pavel Blagodov <stochmail@gmail.com>
ns-codereview pushed a commit that referenced this pull request Apr 4, 2019
@robashcom
Stat Names/Descriptions Re-Write #1
05f76f0 
- Renamed all stats & edited descriptions
- Changed some group membership w/ KV stats - more to come

Change-Id: I6f4d9587e36c80ddc14191f43b185d8955570c04
Reviewed-on: http://review.couchbase.org/107318
Reviewed-by: Rob Ashcom <rob.ashcom@gmail.com>
Tested-by: Rob Ashcom <rob.ashcom@gmail.com>
ns-codereview pushed a commit that referenced this pull request Aug 29, 2024
@timofey-barmin
MB-61292: Add cb_atomic_persistent_term
dfaf2e0 
The idea is to modify encryption keys in persistent_term atomically
and avoid scenarios like:

1. proc1 reads keys from disk
2. proc3 changes keys are changed on disk
3. proc2 reads keys from disk
3. proc2 writes keys to persistent_term based on #3
4. proc1 writes keys to persistent_term based on #1 (overwrites #2)

Change-Id: I8d08717170e7b9c920778b7918fc74877d06bbe8
Reviewed-on: https://review.couchbase.org/c/ns_server/+/213279
Tested-by: Timofey Barmin <timofey.barmin@couchbase.com>
Reviewed-by: Navdeep S Boparai <navdeep.boparai@couchbase.com>
Well-Formed: Build Bot <build@couchbase.com>
ns-codereview pushed a commit that referenced this pull request Sep 27, 2024
@timofey-barmin
MB-61292: Fix for PUT /../secrets/<ID>
c296733 
Fix permissions check: should check not only usages that are being
set but also usages that are being replaced. Without this check,
for example, bucket admin can overwrite a secret created by full
admin that was supposed to be used for things like config encryption.

Also this change fixes a race scenario when two parallel changes can
hypothetically overwrite some settings of the secret being modified:
1. PUT takes current secret properties and prepares new properties
   based on that value;
2. Another process modifies some secret properties (auto-rotation);
3. PUT finishes and sets the properties prepared at step #1
4. Change made by step #2 is lost

This obvious race was considered imposible in the very first
implementation, but then after several changes it became possible:(

Change-Id: I3c508e9eb8d8b367bc63bb8aaadfc050c4204160
Reviewed-on: https://review.couchbase.org/c/ns_server/+/216863
Tested-by: Timofey Barmin <timofey.barmin@couchbase.com>
Well-Formed: Build Bot <build@couchbase.com>
Reviewed-by: Navdeep S Boparai <navdeep.boparai@couchbase.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@xiejunyi