Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CBG-3212: add api to fetch a document by its CV value #6579

Merged
merged 9 commits into from
Jan 18, 2024
Merged

CBG-3212: add api to fetch a document by its CV value #6579

merged 9 commits into from
Jan 18, 2024

Conversation

gregns1
Copy link
Contributor

@gregns1 gregns1 commented Nov 16, 2023 •
edited
Loading

CBG-3212

  • Add GetCV function to fetch a document by its specidfied CV
  • Add tests covering the active code opath, the code path where a doc will be resident in the rev cache and the code path where the do will not be resident in the rev cache
  • I have removed some code that I added in the rev cache work that took place. It is code I took from Bens PR on channel information. It has changed since then and found it wasn't actually populating the channels correctly on a doc load from the bucket.

Pre-review checklist

  • Removed debug logging (fmt.Print, log.Print, ...)
  • Logging sensitive data? Make sure it's tagged (e.g. base.UD(docID), base.MD(dbName))
  • Updated relevant information in the API specifications (such as endpoint descriptions, schemas, ...) in docs/api

Integration Tests

@gregns1 gregns1 self-assigned this Nov 16, 2023
@gregns1 gregns1 requested a review from bbrks November 16, 2023 16:35
@gregns1 gregns1 assigned bbrks and unassigned gregns1 Nov 16, 2023
@bbrks bbrks force-pushed the beryllium branch 2 times, most recently from 6a585e9 to 01cc0c0 Compare December 15, 2023 11:21
@bbrks bbrks assigned adamcfraser and unassigned bbrks Jan 16, 2024
@bbrks
Copy link
Member

bbrks commented Jan 16, 2024

Removed dependency on other PR. This one as it stands is ready for review.

adamcfraser
adamcfraser requested changes Jan 16, 2024
View reviewed changes
db/revision_cache_interface.go Outdated Show resolved Hide resolved
db/crud.go Show resolved Hide resolved
torcolvin
torcolvin previously approved these changes Jan 17, 2024
View reviewed changes
db/crud.go Outdated Show resolved Hide resolved
@bbrks @torcolvin
Update db/crud.go
b7a7de4 
Co-authored-by: Tor Colvin <tor.colvin@couchbase.com>
@adamcfraser adamcfraser merged commit 07f4320 into beryllium Jan 18, 2024
17 checks passed
@adamcfraser adamcfraser deleted the CBG-3212 branch January 18, 2024 19:45
bbrks added a commit that referenced this pull request Jan 23, 2024
@gregns1 @bbrks @torcolvin
CBG-3212: add api to fetch a document by its CV value (#6579)
eaa0ade 
* CBG-3212: add api to fetch a document by its CV value

* test fix

* rebased SourceAndVersion -> Version rename

* Update currentRevChannels on CV revcache load and doc.updateChannels

* fix spelling

* Remove currentRevChannels

* Move common GetRev/GetCV work into documentRevisionForRequest function

* Pass revision.RevID into authorizeUserForChannels

* Update db/crud.go

Co-authored-by: Tor Colvin <tor.colvin@couchbase.com>

---------

Co-authored-by: Ben Brooks <ben.brooks@couchbase.com>
Co-authored-by: Tor Colvin <tor.colvin@couchbase.com>
bbrks added a commit that referenced this pull request Apr 9, 2024
@gregns1 @bbrks @torcolvin
CBG-3212: add api to fetch a document by its CV value (#6579)
58b71d7 
* CBG-3212: add api to fetch a document by its CV value

* test fix

* rebased SourceAndVersion -> Version rename

* Update currentRevChannels on CV revcache load and doc.updateChannels

* fix spelling

* Remove currentRevChannels

* Move common GetRev/GetCV work into documentRevisionForRequest function

* Pass revision.RevID into authorizeUserForChannels

* Update db/crud.go

Co-authored-by: Tor Colvin <tor.colvin@couchbase.com>

---------

Co-authored-by: Ben Brooks <ben.brooks@couchbase.com>
Co-authored-by: Tor Colvin <tor.colvin@couchbase.com>
bbrks added a commit that referenced this pull request Apr 16, 2024
@gregns1 @bbrks @torcolvin
CBG-3212: add api to fetch a document by its CV value (#6579)
381538a 
* CBG-3212: add api to fetch a document by its CV value

* test fix

* rebased SourceAndVersion -> Version rename

* Update currentRevChannels on CV revcache load and doc.updateChannels

* fix spelling

* Remove currentRevChannels

* Move common GetRev/GetCV work into documentRevisionForRequest function

* Pass revision.RevID into authorizeUserForChannels

* Update db/crud.go

Co-authored-by: Tor Colvin <tor.colvin@couchbase.com>

---------

Co-authored-by: Ben Brooks <ben.brooks@couchbase.com>
Co-authored-by: Tor Colvin <tor.colvin@couchbase.com>
bbrks added a commit that referenced this pull request Apr 16, 2024
@gregns1 @bbrks @torcolvin
CBG-3212: add api to fetch a document by its CV value (#6579)
9cc8f89 
* CBG-3212: add api to fetch a document by its CV value

* test fix

* rebased SourceAndVersion -> Version rename

* Update currentRevChannels on CV revcache load and doc.updateChannels

* fix spelling

* Remove currentRevChannels

* Move common GetRev/GetCV work into documentRevisionForRequest function

* Pass revision.RevID into authorizeUserForChannels

* Update db/crud.go

Co-authored-by: Tor Colvin <tor.colvin@couchbase.com>

---------

Co-authored-by: Ben Brooks <ben.brooks@couchbase.com>
Co-authored-by: Tor Colvin <tor.colvin@couchbase.com>
adamcfraser pushed a commit that referenced this pull request May 7, 2024
@gregns1 @bbrks
@torcolvin @adamcfraser
CBG-3212: add api to fetch a document by its CV value (#6579)
5d62bae 
* CBG-3212: add api to fetch a document by its CV value

* test fix

* rebased SourceAndVersion -> Version rename

* Update currentRevChannels on CV revcache load and doc.updateChannels

* fix spelling

* Remove currentRevChannels

* Move common GetRev/GetCV work into documentRevisionForRequest function

* Pass revision.RevID into authorizeUserForChannels

* Update db/crud.go

Co-authored-by: Tor Colvin <tor.colvin@couchbase.com>

---------

Co-authored-by: Ben Brooks <ben.brooks@couchbase.com>
Co-authored-by: Tor Colvin <tor.colvin@couchbase.com>
adamcfraser pushed a commit that referenced this pull request May 10, 2024
@gregns1 @bbrks
@torcolvin @adamcfraser
CBG-3212: add api to fetch a document by its CV value (#6579)
15804f6 
* CBG-3212: add api to fetch a document by its CV value

* test fix

* rebased SourceAndVersion -> Version rename

* Update currentRevChannels on CV revcache load and doc.updateChannels

* fix spelling

* Remove currentRevChannels

* Move common GetRev/GetCV work into documentRevisionForRequest function

* Pass revision.RevID into authorizeUserForChannels

* Update db/crud.go

Co-authored-by: Tor Colvin <tor.colvin@couchbase.com>

---------

Co-authored-by: Ben Brooks <ben.brooks@couchbase.com>
Co-authored-by: Tor Colvin <tor.colvin@couchbase.com>
adamcfraser pushed a commit that referenced this pull request May 14, 2024
@gregns1 @bbrks
@torcolvin @adamcfraser
CBG-3212: add api to fetch a document by its CV value (#6579)
72ab448 
* CBG-3212: add api to fetch a document by its CV value

* test fix

* rebased SourceAndVersion -> Version rename

* Update currentRevChannels on CV revcache load and doc.updateChannels

* fix spelling

* Remove currentRevChannels

* Move common GetRev/GetCV work into documentRevisionForRequest function

* Pass revision.RevID into authorizeUserForChannels

* Update db/crud.go

Co-authored-by: Tor Colvin <tor.colvin@couchbase.com>

---------

Co-authored-by: Ben Brooks <ben.brooks@couchbase.com>
Co-authored-by: Tor Colvin <tor.colvin@couchbase.com>
torcolvin added a commit that referenced this pull request May 21, 2024
@gregns1 @bbrks @torcolvin
CBG-3212: add api to fetch a document by its CV value (#6579)
1d943a7 
* CBG-3212: add api to fetch a document by its CV value

* test fix

* rebased SourceAndVersion -> Version rename

* Update currentRevChannels on CV revcache load and doc.updateChannels

* fix spelling

* Remove currentRevChannels

* Move common GetRev/GetCV work into documentRevisionForRequest function

* Pass revision.RevID into authorizeUserForChannels

* Update db/crud.go

Co-authored-by: Tor Colvin <tor.colvin@couchbase.com>

---------

Co-authored-by: Ben Brooks <ben.brooks@couchbase.com>
Co-authored-by: Tor Colvin <tor.colvin@couchbase.com>
adamcfraser pushed a commit that referenced this pull request May 27, 2024
@gregns1 @bbrks
@torcolvin @adamcfraser
CBG-3212: add api to fetch a document by its CV value (#6579)
5de97a8 
* CBG-3212: add api to fetch a document by its CV value

* test fix

* rebased SourceAndVersion -> Version rename

* Update currentRevChannels on CV revcache load and doc.updateChannels

* fix spelling

* Remove currentRevChannels

* Move common GetRev/GetCV work into documentRevisionForRequest function

* Pass revision.RevID into authorizeUserForChannels

* Update db/crud.go

Co-authored-by: Tor Colvin <tor.colvin@couchbase.com>

---------

Co-authored-by: Ben Brooks <ben.brooks@couchbase.com>
Co-authored-by: Tor Colvin <tor.colvin@couchbase.com>
adamcfraser pushed a commit that referenced this pull request Aug 11, 2024
@gregns1 @bbrks
@torcolvin @adamcfraser
CBG-3212: add api to fetch a document by its CV value (#6579)
2e3b5e3 
* CBG-3212: add api to fetch a document by its CV value

* test fix

* rebased SourceAndVersion -> Version rename

* Update currentRevChannels on CV revcache load and doc.updateChannels

* fix spelling

* Remove currentRevChannels

* Move common GetRev/GetCV work into documentRevisionForRequest function

* Pass revision.RevID into authorizeUserForChannels

* Update db/crud.go

Co-authored-by: Tor Colvin <tor.colvin@couchbase.com>

---------

Co-authored-by: Ben Brooks <ben.brooks@couchbase.com>
Co-authored-by: Tor Colvin <tor.colvin@couchbase.com>
adamcfraser pushed a commit that referenced this pull request Aug 11, 2024
@gregns1 @bbrks
@torcolvin @adamcfraser
CBG-3212: add api to fetch a document by its CV value (#6579)
e0fd6f2 
* CBG-3212: add api to fetch a document by its CV value

* test fix

* rebased SourceAndVersion -> Version rename

* Update currentRevChannels on CV revcache load and doc.updateChannels

* fix spelling

* Remove currentRevChannels

* Move common GetRev/GetCV work into documentRevisionForRequest function

* Pass revision.RevID into authorizeUserForChannels

* Update db/crud.go

Co-authored-by: Tor Colvin <tor.colvin@couchbase.com>

---------

Co-authored-by: Ben Brooks <ben.brooks@couchbase.com>
Co-authored-by: Tor Colvin <tor.colvin@couchbase.com>
adamcfraser pushed a commit that referenced this pull request Aug 13, 2024
@gregns1 @bbrks
@torcolvin @adamcfraser
CBG-3212: add api to fetch a document by its CV value (#6579)
04bcf79 
* CBG-3212: add api to fetch a document by its CV value

* test fix

* rebased SourceAndVersion -> Version rename

* Update currentRevChannels on CV revcache load and doc.updateChannels

* fix spelling

* Remove currentRevChannels

* Move common GetRev/GetCV work into documentRevisionForRequest function

* Pass revision.RevID into authorizeUserForChannels

* Update db/crud.go

Co-authored-by: Tor Colvin <tor.colvin@couchbase.com>

---------

Co-authored-by: Ben Brooks <ben.brooks@couchbase.com>
Co-authored-by: Tor Colvin <tor.colvin@couchbase.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torcolvin torcolvin torcolvin approved these changes

@adamcfraser adamcfraser adamcfraser approved these changes

@bbrks bbrks Awaiting requested review from bbrks

Assignees

@adamcfraser adamcfraser

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gregns1 @bbrks @torcolvin @adamcfraser