Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CBG-3026: Use DatabaseInitManager in all GSI cases #7121

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

CBG-3026: Use DatabaseInitManager in all GSI cases #7121

wants to merge 11 commits into from
+264 −183

Commits on Sep 24, 2024

  1. Rework database initialization code to reuse DatabaseInitManager in… 

    … all GSI cases (including persistent config) to centralize and de-duplicate index creation code
    @bbrks
    bbrks committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    afff476 View commit details
    Browse the repository at this point in the history

  2. Fix synchronous online logic and view-init when set of collections do… 

    …esn't include _default
    @bbrks
    bbrks committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    8ca98e0 View commit details
    Browse the repository at this point in the history

  3. Use a dbCtx field to determine whether init was async or not

    @bbrks
    bbrks committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    3bf85e8 View commit details
    Browse the repository at this point in the history

  4. Fix missing credentials in the non-persistent config + GSI combinatio… 

    …n (indirectly caught by TestValidateServerContextSharedBuckets)
    @bbrks
    bbrks committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    3a34a5e View commit details
    Browse the repository at this point in the history

  5. Populate the db creds in DatabaseInit manager tests like the real cod… 

    …epaths do
    @bbrks
    bbrks committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    7f288b8 View commit details
    Browse the repository at this point in the history

  6. CloseClusterOnlyN1QLStore when we're done with db init in manager

    @bbrks
    bbrks committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    5b99aa0 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Add missing dbConfig.setup in dbinitmanager tests

    @bbrks
    bbrks committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    dfba2b1 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. Address PR comments

    @bbrks
    bbrks committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    1d4e485 View commit details
    Browse the repository at this point in the history

  2. Always use database config server/bucket/creds/etc. when initializing… 

    … (allows legacy configs with unique servers on each database to continue working). Had to be manually tested.
    @bbrks
    bbrks committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    0fa6c46 View commit details
    Browse the repository at this point in the history

  3. Drop StartupConfig parameter so it's impossible to accidentally use t… 

    …he wrong server/bucket/credentials
    @bbrks
    bbrks committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    1dc68b9 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. Remove GetClusterN1QLStore which creates un-closable connection in … 

    …some cases, and replace with explicit connection in `InitializeDatabase`
    @bbrks
    bbrks committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    c1189ff View commit details
    Browse the repository at this point in the history