[3.2.1 Backport] CBG-4075: do not release doc sequence upon timeout error #7133
+141
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to release sequences in scenarios where we know the write did not occur.
bbrks
changed the title
adamcfraser
approved these changes
Sep 27, 2024
bbrks
added a commit
that referenced
this pull request
Oct 8, 2024
…rror (#7133) * CBG-4067: do not release doc sequence upon timeout error (#7016) * CBG-4067 Only skip releasing sequences for timeouts (#7050) We want to release sequences in scenarios where we know the write did not occur. --------- Co-authored-by: Gregory Newman-Smith <109068393+gregns1@users.noreply.github.com> Co-authored-by: Adam Fraser <adam.fraser@couchbase.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CBG-4075
Clean cherry-picks of #7016 and #7050 for 3.2.1 (CBG-4067)
Integration Tests
GSI=true,xattrs=truehttps://jenkins.sgwdev.com/job/SyncGateway-Integration/2724/