Fixing issues when puppet runs as service

README.md

@@ -132,6 +132,16 @@ windows::unzip { 'C:\compressed.zip':
 }
 ```
 
+If you don't have .NET 4.5 installed you can fallback to COM based method but it can fail if puppet runs as service. 
+
+```puppet
+windows::unzip { 'C:\compressed.zip':
+  destination => 'C:\dest',
+  creates     => 'C:\dest\uncompressed.txt',
+  fallback    => true,
+}
+```
+
 This assumes that the file `uncompressed.txt` exists in `C:\compressed.zip`
 
 License

manifests/unzip.pp

@@ -52,21 +52,29 @@
   $zipfile          = $name,
   $provider         = 'powershell',
   $options          = '20',
-  $command_template = 'windows/unzip.ps1.erb',
   $timeout          = 300,
+  $logoutput        = on_failure,
+  $fallback         = false,
 ) {
   validate_absolute_path($destination)
 
   if (! $creates and ! $refreshonly and ! $unless){
     fail("Must set one of creates, refreshonly, or unless parameters.\n")
   }
 
+  if ($fallback){
+    $command_template = 'windows/unzip.ps1.erb'
+  } else{
+    $command_template = 'windows/unzip_dotnet.ps1.erb'
+  }
+
   exec { "unzip-${name}":
     command     => template($command_template),
     creates     => $creates,
     refreshonly => $refreshonly,
     unless      => $unless,
     provider    => $provider,
     timeout     => $timeout,
+    logoutput   => $logoutput,
   }
 }

templates/unzip.ps1.erb

@@ -1,3 +1,22 @@
-$shell = New-Object -COMObject Shell.Application;
-$zipfile = $shell.NameSpace("<%= @zipfile %>");
-foreach($item in $zipfile.Items()){ $shell.NameSpace("<%= @destination %>").CopyHere($item, <%= @options %>) };
+$zipFile="<%= @zipfile %>"
+$dst="<%= @destination %>"
+
+if ( ! (Test-Path $zipfile) ) {
+    write-error "ZIP file does not exists: `$zipFile'"
+    exit 1
+}
+
+if ( ! (Test-Path $dst) ) {
+    write-error "Missing destination folder: `$dst'"
+    exit 1
+}
+
+try {
+    $shell = New-Object -COMObject Shell.Application;
+    $zipfile = $shell.NameSpace("<%= @zipfile %>");
+    foreach($item in $zipfile.Items()){ $shell.NameSpace("<%= @destination %>").CopyHere($item, <%= @options %>) };
+}
+catch {
+    write-error $_
+    exit 1
+}

templates/unzip_dotnet.ps1.erb

@@ -0,0 +1,21 @@
+$zipFile="<%= @zipfile %>"
+$dst="<%= @destination %>"
+
+if ( ! (Test-Path $zipfile) ) {
+    write-error "ZIP file does not exists: ``$zipFile'"
+    exit 1
+}
+
+if ( ! (Test-Path $dst) ) {
+    write-error "Missing destination folder: ``$dst'"
+    exit 1
+}
+
+try {
+    Add-Type -A System.IO.Compression.FileSystem
+    [IO.Compression.ZipFile]::ExtractToDirectory($zipFile, $dst)
+}
+catch {
+    write-error $_
+    exit 1
+}