Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): ensure poetry export returns index credentials #67

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

dotboris
Copy link
Contributor

This PR fixes an issue when using stew build with a private password protected registry. When stew downloads the wheels for all dependencies, it does so by calling poetry export followed by pip wheels.

If you happen to have a primary source configured in your pyproject.toml and that this primary source is password protected, you'll get an error about pip being unable to resolve any package in your project.

This happens because by default poetry export adds an --index-url in its output but the URL it produces doesn't include credentials. This PR changes the way poetry export is called so that the --index-url now includes any credentials if they're preset.

@dotboris dotboris requested review from jonapich, pballandras and a team November 14, 2024 18:24
@jonapich jonapich merged commit babaf16 into main Nov 14, 2024
20 checks passed
@jonapich jonapich deleted the DT-7452/build-index-with-creds branch November 14, 2024 19:21
@jonapich
Copy link
Member

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants