Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch base tsconfig to github.com/tsconfig/bases #4325

Merged
merged 10 commits into from
Aug 30, 2024
Merged

Conversation

alexprudhomme
Copy link
Contributor

@alexprudhomme alexprudhomme commented Aug 27, 2024

https://coveord.atlassian.net/browse/KIT-2614

Ran into this while trying to do KIT-2611.

  • Update the tsconfig extend to a more recent one
  • Update the two headless react proejcts to use vite (react scripts is outdated and abandoned, it was causing me problems)

@alexprudhomme alexprudhomme marked this pull request as ready for review August 27, 2024 14:43
@alexprudhomme alexprudhomme requested a review from a team as a code owner August 27, 2024 14:43
@alexprudhomme alexprudhomme changed the title Kit 2614 chore: switch base tsconfig to github.com/tsconfig/bases Aug 27, 2024
Copy link

github-actions bot commented Aug 28, 2024

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 244.1 244.3 0.1
commerce 344.1 344.3 0.1
search 417.8 418.1 0.1
insight 394.5 394.7 0.1
product-listing 308.4 308.6 0.1
product-recommendation 214.9 215.2 0.1
recommendation 257.9 258.1 0.1
ssr 407.8 408 0.1
ssr-commerce 354.7 354.9 0.1

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
product-recommendation 0 10 0
product-listing 0 13 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
product-recommendation : missing SSR support
product-listing : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@alexprudhomme alexprudhomme added this pull request to the merge queue Aug 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 29, 2024
@alexprudhomme alexprudhomme added this pull request to the merge queue Aug 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 29, 2024
@alexprudhomme alexprudhomme added this pull request to the merge queue Aug 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 29, 2024
@alexprudhomme alexprudhomme added this pull request to the merge queue Aug 30, 2024
Merged via the queue into master with commit efdc2b2 Aug 30, 2024
117 checks passed
@alexprudhomme alexprudhomme deleted the KIT-2614 branch August 30, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants