feat(atomic, headless): add support for sort criteria alphanumericNatural #4493
+163
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
fpbrault
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
fpbrault
requested review from
olamothe,
y-lakhdar,
louis-bompart and
alexprudhomme
fpbrault
had a problem deploying
to
PR Artifacts
GitHub Actions
Error
fpbrault
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
fpbrault
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
| @@ -174,7 +174,7 @@ export class AtomicFacet implements InitializableComponent { | |||
| @Prop({reflect: true}) public withSearch = true; | |||
| /** | |||
| * The sort criterion to apply to the returned facet values. | |||
| * Possible values are 'score', 'alphanumeric', 'alphanumericDescending', 'occurrences', and 'automatic'. | |||
| * Possible values are 'score', 'alphanumeric', 'alphanumericDescending', 'occurrences', alphanumericNatural', 'alphanumericNaturalDescending' and 'automatic'. | |||
| */ | |||
| @Prop({reflect: true}) public sortCriteria: FacetSortCriterion = 'automatic'; | |||
There was a problem hiding this comment.
The interface FacetSortCriterion does not contain alphanumericNatural' & alphanumericNaturalDescending.
There was a problem hiding this comment.
This PR adds them!
Comment on lines
+1
to
+2
| import {FacetSortCriterion} from '@coveo/headless'; | ||
| import {orderBy} from 'natural-orderby'; |
There was a problem hiding this comment.
I don't think adding a dependency is necessary for tests. Is there other ways you can test this ? Or at least put it in devDependencies ?
There was a problem hiding this comment.
Yep def should be in dev deps. Extracting the sorting logic from natural-orderby would be too much work.
I tried with natural-compare-lite and javascript-natural-sort, which are already in our deps, but they don't sort in the same way as the index...
fpbrault
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
fpbrault
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the alphanumericNatural and alphanumericNaturalDescending sort criteria for facets in headless and atomic.
https://coveord.atlassian.net/browse/KIT-3528