-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(atomic): add tests for atomic-product-description/atomic-product-excerpt #4547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
fpbrault
force-pushed
the
KIT-3266
branch
2 times, most recently
from
October 16, 2024 21:01
6b2e7ba
to
cf930e3
Compare
fpbrault
changed the title
test(atomic): add tests for atomic-product-description
test(atomic): add tests for atomic-product-description/atomic-product-excerpt
Oct 16, 2024
fpbrault
requested review from
olamothe,
y-lakhdar,
louis-bompart and
fbeaudoincoveo
October 16, 2024 21:09
fbeaudoincoveo
requested changes
Oct 17, 2024
...product-template-components/atomic-product-description/e2e/atomic-product-description.e2e.ts
Show resolved
Hide resolved
...ommerce/product-template-components/atomic-product-excerpt/e2e/atomic-product-excerpt.e2e.ts
Show resolved
Hide resolved
...product-template-components/atomic-product-description/e2e/atomic-product-description.e2e.ts
Show resolved
Hide resolved
...ommerce/product-template-components/atomic-product-excerpt/e2e/atomic-product-excerpt.e2e.ts
Show resolved
Hide resolved
closing as I'm merging this with #4541 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds playwright tests for atomic-product-description and atomic-product-excerpt
https://coveord.atlassian.net/browse/KIT-3266