Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(atomic): add tests for atomic-product-description/atomic-product-excerpt #4547

Closed
wants to merge 7 commits into from

Conversation

fpbrault
Copy link
Contributor

@fpbrault fpbrault commented Oct 16, 2024

This PR adds playwright tests for atomic-product-description and atomic-product-excerpt

https://coveord.atlassian.net/browse/KIT-3266

Copy link

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 236.6 236.6 0
commerce 339.3 339.3 0
search 412 412 0
insight 400 400 0
recommendation 248.8 248.8 0
ssr 405.7 405.7 0
ssr-commerce 351.6 351.6 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@fpbrault fpbrault force-pushed the KIT-3266 branch 2 times, most recently from 6b2e7ba to cf930e3 Compare October 16, 2024 21:01
@fpbrault fpbrault changed the title test(atomic): add tests for atomic-product-description test(atomic): add tests for atomic-product-description/atomic-product-excerpt Oct 16, 2024
@fpbrault fpbrault marked this pull request as ready for review October 16, 2024 21:09
@fpbrault fpbrault requested a review from a team as a code owner October 16, 2024 21:09
@fpbrault
Copy link
Contributor Author

closing as I'm merging this with #4541

@fpbrault fpbrault closed this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants