Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(atomic): allow atomic loader to be deployed to the CDN #4568

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

alexprudhomme
Copy link
Contributor

@alexprudhomme alexprudhomme commented Oct 21, 2024

https://coveord.atlassian.net/browse/KIT-3666

This PR allows the defineCustomElements() function to be deployed to the CDN by simply adding it into the /dist folder instead of it's custom folder.

It causes a problem in atomic-react where the defineCustomElements import becomes "import { defineCustomElements } from '@coveo/atomic/dist/loader';".
That import is invalid because of the added exports field in atomic V3. To fix this, we need to change the import back to how it was. I created a script to do this. It changes it back to "import { defineCustomElements } from '@coveo/atomic/loader';".

@alexprudhomme alexprudhomme requested a review from a team as a code owner October 21, 2024 20:20
@alexprudhomme alexprudhomme changed the title fix(atomic): deploy atomic loader to the CDN fix(atomic): allow atomic loader to be deployed to the CDN Oct 21, 2024
Copy link

github-actions bot commented Oct 21, 2024

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 236.6 236.6 0
commerce 340.5 340.5 0
search 412 412 0
insight 400 400 0
recommendation 248.8 248.8 0
ssr 405.7 405.7 0
ssr-commerce 352.8 352.8 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@alexprudhomme alexprudhomme marked this pull request as ready for review October 22, 2024 17:53
Copy link
Collaborator

@louis-bompart louis-bompart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GG

@alexprudhomme alexprudhomme added this pull request to the merge queue Oct 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 23, 2024
@alexprudhomme alexprudhomme added this pull request to the merge queue Oct 23, 2024
Merged via the queue into master with commit b579cb0 Oct 24, 2024
93 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants