-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(atomic): allow atomic loader to be deployed to the CDN #4568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexprudhomme
requested review from
olamothe,
fpbrault,
y-lakhdar and
louis-bompart
October 21, 2024 20:20
alexprudhomme
changed the title
fix(atomic): deploy atomic loader to the CDN
fix(atomic): allow atomic loader to be deployed to the CDN
Oct 21, 2024
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
alexprudhomme
temporarily deployed
to
PR Artifacts
October 21, 2024 20:34
— with
GitHub Actions
Inactive
alexprudhomme
force-pushed
the
KIT-3666
branch
from
October 22, 2024 13:53
1ba3b64
to
e1a69be
Compare
alexprudhomme
temporarily deployed
to
PR Artifacts
October 22, 2024 14:03
— with
GitHub Actions
Inactive
alexprudhomme
commented
Oct 22, 2024
alexprudhomme
temporarily deployed
to
PR Artifacts
October 22, 2024 18:03
— with
GitHub Actions
Inactive
fbeaudoincoveo
approved these changes
Oct 22, 2024
louis-bompart
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GG
alexprudhomme
temporarily deployed
to
PR Artifacts
October 23, 2024 19:05
— with
GitHub Actions
Inactive
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 23, 2024
alexprudhomme
temporarily deployed
to
PR Artifacts
October 24, 2024 00:02
— with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://coveord.atlassian.net/browse/KIT-3666
This PR allows the
defineCustomElements()
function to be deployed to the CDN by simply adding it into the/dist
folder instead of it's custom folder.It causes a problem in atomic-react where the
defineCustomElements
import becomes"import { defineCustomElements } from '@coveo/atomic/dist/loader';"
.That import is invalid because of the added
exports
field in atomic V3. To fix this, we need to change the import back to how it was. I created a script to do this. It changes it back to"import { defineCustomElements } from '@coveo/atomic/loader';"
.