Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(quantic): fix search box scroll issue #4573

Merged
merged 4 commits into from
Oct 24, 2024
Merged

fix(quantic): fix search box scroll issue #4573

merged 4 commits into from
Oct 24, 2024

Conversation

mmitiche
Copy link
Contributor

@mmitiche mmitiche commented Oct 22, 2024

SFINT-5775

  1. First issue: search box scroll

When first loading the search page with a multiline query, the search box was containing an unexpected scroll bar:

searchbox.scroll.mov
  1. Second issue: z-index of filter count badge:
Screen.Recording.2024-10-22.at.9.03.49.AM.mov

@mmitiche mmitiche requested a review from a team as a code owner October 22, 2024 11:51
Copy link

github-actions bot commented Oct 22, 2024

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 236.6 236.6 0
commerce 341.4 341.4 0
search 412.3 412.3 0
insight 400.3 400.3 0
recommendation 248.8 248.8 0
ssr 406 406 0
ssr-commerce 353.5 353.5 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@mmitiche mmitiche added this pull request to the merge queue Oct 24, 2024
Merged via the queue into master with commit aa7afda Oct 24, 2024
99 checks passed
@mmitiche mmitiche deleted the SFINT-5775 branch October 24, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants