update lockfile v2 again #4575
Closed
update lockfile v2 again #4575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
louis-bompart
commented
Oct 22, 2024
louis-bompart
commented
- chore: setup v2 legacy releases (chore: setup v2 legacy releases #4319)
- test: run only on chrome (test: run only on chrome #4344)
- fix(atomic): field sort should be applied when selected (fix(atomic): field sort should be applied when selected #4345)
- ci: change npm tags for v2, disable sfdx release (ci: change npm tags for v2, disable sfdx release #4352)
- fix(atomic): do not add click outside of grid layout (fix(atomic): do not add click outside of grid layout #4354)
- fix(atomic-react): deprecate analytics from atomic search interface (fix(atomic-react): deprecate analytics from atomic search interface #4342)
- [Version Bump][skip ci]: ui-kit publish
- ci: use github checks api (ci: use github checks api #4373)
- ci: ensure we tag on a non semver-range (ci: ensure we tag on a non semver-range #4360)
- fix(atomic): use getter instead of fn (fix(atomic): use getter instead of fn #4395)
- chore: provide version (cd: provide version #4415)
- [Version Bump][skip ci]: ui-kit publish
- chore: ensure angular tags v2-latest in v2 (chore: ensure angular tags v2-latest in v2 #4418)
- fix(answerApi): custom event (fix(answerApi): custom event #4478)
- chore: update plock (chore: update plock #4504)
- fix(genqa): fix rga feedback position with chrome (fix(genqa): fix rga feedback position with chrome #4501)
- fix(headless): ensure each result keep a reference of its 'source' searchId V2 (fix(headless): ensure each result keep a reference of its 'source' searchId V2 #4510)
- test(atomic): fix failing atomic-color-facet test because of source change (test(atomic): fix failing atomic-color-facet test because of source change #4560)
- chore: ensure we check only the tags from the current release branch (chore: ensure we check only the tags from the current release branch #4558)
- test(quantic): fixed quantic e2e after salesforce 25 winter release (test(quantic): fixed quantic e2e after salesforce 25 winter release #4570)
- fix(atomic,quantic): broken HTML because of formatting in CRGA markdown heading (fix(atomic,quantic): broken HTML because of formatting in CRGA markdown heading #4564)
- chore: lockfile update
@coveo/bueno@0.46.2 @coveo/headless@2.80.1 @coveo/atomic@2.78.1 @coveo/headless-react@1.1.5 @coveo/atomic-react@2.14.1 @coveo/atomic-angular@2.28.1 @coveo/auth@1.11.23 @coveo/atomic-hosted-page@0.6.8 @coveo/quantic@2.57.2 **/CHANGELOG.md **/package.json CHANGELOG.md package.json package-lock.json
@coveo/bueno@0.46.3 @coveo/headless@2.80.2 @coveo/atomic@2.78.2 @coveo/headless-react@1.1.6 @coveo/atomic-react@2.14.2 @coveo/atomic-angular@2.28.2 @coveo/auth@1.11.24 @coveo/atomic-hosted-page@0.6.9 @coveo/quantic@2.57.3 **/CHANGELOG.md **/package.json CHANGELOG.md package.json package-lock.json
# V2 This PR backports #4405 into the V2 branch. ## This is a fix Since we should not backport features to the V2 branch, I will defend that this PR is indeed a fix for the whole answer api feature on V2. Without this. The whole feature is unusable for customers to test the answerAPI properly. And will furthermore hinder the momentum we could have to incentive them to move to v3 with the rest of the feature we will add to the answerAPI in the next sprints. Co-authored-by: Danny Gauthier <dgauthier@WKS-002169.corp.coveo.com>
[SVCC-4217](https://coveord.atlassian.net/browse/SVCC-4217) **Before:**  **After:**  [SVCC-4217]: https://coveord.atlassian.net/browse/SVCC-4217?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
…archId V2 (#4510) Make sure to keep the id of the search that returned each result. https://coveord.atlassian.net/browse/KIT-3481 backporting #4391
…4570) [SFINT-5779](https://coveord.atlassian.net/browse/SFINT-5779) This PR backports the fix made [here](#4559). It is mandatory in order to be able to merge other Quantic fixes in `v2`. [SFINT-5779]: https://coveord.atlassian.net/browse/SFINT-5779?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --------- Co-authored-by: mmitiche <mmitiche@coveo.com>
…wn heading (#4564) [SVCC-4245](https://coveord.atlassian.net/browse/SVCC-4245) A CRGA model generally generates markdown headings like this: ``` # Title ``` However, in some cases, it can generate headings this way: ``` **Title** ===== ``` When it does, the HTML returned by the `generated-answer` component is broken and the heading reads like this: ``` Title>Title ``` The core of the issue is in the custom Marked renderer. When the heading has formatting, the `text` parameter contains the HTML rendering of the heading content. Inserting non-escaped HTML into the `aria-label` attribute then breaks the `div` element. This PR fixes the issue by affecting only the heading text content to the `aria-label` attribute. To do so, the HTML elements are removed from the heading content when setting `aria-label`. The heading content HTML is kept intact when setting the heading inner HTML though in order to keep the heading formatting. For example: ``` **Title** ===== ``` Would generate this HTML ``` <div part="answer-heading-1" aria-label="Title"> <strong part="answer-strong">Title</strong> </div> ``` [SVCC-4245]: https://coveord.atlassian.net/browse/SVCC-4245?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ Co-authored-by: Louis Bompart <lbompart@coveo.com>
louis-bompart
requested review from
olamothe,
fpbrault,
y-lakhdar,
fbeaudoincoveo and
erocheleau
louis-bompart
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
louis-bompart
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.