-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(quantic): improved the logic that displays view events as links #4579
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, we forgot to catch that :s
just a small suggestion
packages/quantic/force-app/main/default/lwc/quanticUserAction/quanticUserAction.js
Show resolved
Hide resolved
The view events with a link are actually the exception and not the rule. A View event typically will have a @contentIdKey that should be a Coveo field name (example sfid) and the value would be that value for this result in the coveo index so it can be found again. As a very last resort, the page view tracker will send the current page's url when it can't find anything else to pick. However I see you simply replicated what was in the search-ui-extensions repo so that's perfect ;) |
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
SFINT-5774
The issue
some view events come without a clickuri , for example the following view event:
this events yielded the following behaviour: opening an invalid page in salesforce.
Screen.Recording.2024-10-22.at.1.45.31.PM.mov
usually the view events come with the following format:
where
content_id_key
contains the clickableuri so we are able to display this event as linkThe solution
I updated the logic of the QuanticUserAction component to only display a view event as link only when
content_id_key
contains the@clickableuri
.This is equivalent to the previous implementation of user actions.
content_id_key
does not contain the@clickableuri
content_id_key
contains the@clickableuri