-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(atomic-react): remove traces of npm imports #4581
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexprudhomme
temporarily deployed
to
PR Artifacts
October 22, 2024 20:08
— with
GitHub Actions
Inactive
alexprudhomme
temporarily deployed
to
PR Artifacts
October 22, 2024 20:34
— with
GitHub Actions
Inactive
alexprudhomme
temporarily deployed
to
PR Artifacts
October 23, 2024 13:44
— with
GitHub Actions
Inactive
alexprudhomme
temporarily deployed
to
PR Artifacts
October 23, 2024 14:14
— with
GitHub Actions
Inactive
alexprudhomme
commented
Oct 23, 2024
alexprudhomme
requested review from
olamothe,
fpbrault,
y-lakhdar and
fbeaudoincoveo
October 23, 2024 14:44
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
alexprudhomme
temporarily deployed
to
PR Artifacts
October 23, 2024 21:16
— with
GitHub Actions
Inactive
louis-bompart
force-pushed
the
KIT-3659
branch
from
October 25, 2024 14:09
d651058
to
4cb4c40
Compare
louis-bompart
approved these changes
Oct 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VG PR 👍
louis-bompart
temporarily deployed
to
PR Artifacts
October 25, 2024 14:23
— with
GitHub Actions
Inactive
fbeaudoincoveo
approved these changes
Oct 25, 2024
fpbrault
approved these changes
Oct 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job!
alexprudhomme
temporarily deployed
to
PR Artifacts
October 28, 2024 13:09
— with
GitHub Actions
Inactive
alexprudhomme
temporarily deployed
to
PR Artifacts
October 28, 2024 15:20
— with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://coveord.atlassian.net/browse/KIT-3659
This PR main goal is to fix the ESM output in the CDN by removing the traces of npm imports.
This is achieved by two things.
before 😆
after 😆
This is the current state of the dist folder.
Add @coveo/atomic/loader to the list of cdn externalizations. https://github.com/coveo/ui-kit/pull/4581/files#r1812922022
Fix the ouptput in the CDN it now looks something like this for the proper files :