feat(headless ssr): refresh recommendations server-side #4617
+910
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y-lakhdar
commented
Oct 31, 2024
packages/headless/src/controllers/commerce/recommendations/headless-recommendations.ssr.ts
Outdated
Show resolved
Hide resolved
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
y-lakhdar
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
y-lakhdar
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
y-lakhdar
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
y-lakhdar
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
y-lakhdar
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
y-lakhdar
commented
Nov 4, 2024
| return { | ||
| search: true, | ||
| listing: true, | ||
| standalone: true, | ||
| _recommendationProps: { |
There was a problem hiding this comment.
We need this flag so when we manipulate controller definition, we know which one is a recommendation definition.
y-lakhdar
changed the title
y-lakhdar
changed the title
y-lakhdar
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding server-side rendering on both commerce and non commerce ssr packages.
Warning:
This introduces a breaking change on how we pass the search action during the hydratation
TODO:
recommendationDefinitions. this will be the only definition where the recommendations will be refreshed.https://coveord.atlassian.net/browse/KIT-3503