-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add build to deployment composante + nightly flag #4655
Open
louis-bompart
wants to merge
4
commits into
master
Choose a base branch
from
chore/manual-nightly-v3-deployment
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+73
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louis-bompart
had a problem deploying
to
PR Artifacts
November 7, 2024 22:05
— with
GitHub Actions
Failure
louis-bompart
had a problem deploying
to
PR Artifacts
November 7, 2024 22:26
— with
GitHub Actions
Failure
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
louis-bompart
temporarily deployed
to
PR Artifacts
November 8, 2024 03:37
— with
GitHub Actions
Inactive
louis-bompart
temporarily deployed
to
PR Artifacts
November 8, 2024 06:07
— with
GitHub Actions
Inactive
louis-bompart
changed the title
make build script nightly-ready
chore: add build to deployment composante + nightly flag
Nov 8, 2024
louis-bompart
requested review from
olamothe,
fpbrault,
y-lakhdar and
alexprudhomme
November 8, 2024 15:19
louis-bompart
temporarily deployed
to
PR Artifacts
November 8, 2024 15:31
— with
GitHub Actions
Inactive
louis-bompart
temporarily deployed
to
PR Artifacts
November 8, 2024 18:41
— with
GitHub Actions
Inactive
louis-bompart
temporarily deployed
to
PR Artifacts
November 8, 2024 19:11
— with
GitHub Actions
Inactive
alexprudhomme
approved these changes
Nov 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So how would we trigger this ?
Is it a github action in ui-kit-cd ? |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 11, 2024
This PR adds a new kind of deployment: nightly deployments. Quick-fire descriptions of Nightly Deployments: - They are only for the CDN - They are not for direct consumer uses (i.e. only Hosted Services may use them directly as "stop-gap" measure between official releases. - They are triggered manually - They only target a single "CDN path" per project & major (i.e. no `v3.0-nightly`, or `v3.0.1-nightly`, only `v3-nightly` This PR concerns v2 deployment. Find the two related PR: - coveo-platform/ui-kit-cd#44 this one for "how the thing will be actually dispatched" - #4655 is the equivalent for master.
Yes 👍 |
louis-bompart
force-pushed
the
chore/manual-nightly-v3-deployment
branch
from
November 13, 2024 19:56
070f09b
to
ad0ff81
Compare
louis-bompart
temporarily deployed
to
PR Artifacts
November 13, 2024 20:12
— with
GitHub Actions
Inactive
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new kind of deployment: nightly deployments.
Quick-fire descriptions of Nightly Deployments:
They are only for the CDN
They are not for direct consumer uses (i.e. only Hosted Services may use them directly as "stop-gap" measure between official releases.
They are triggered manually
They only target a single "CDN path" per project & major (i.e. no v3.0-nightly, or v3.0.1-nightly, only v3-nightly
This PR concerns v3 deployment. Find the two related PR:
https://github.com/coveo-platform/ui-kit-cd/pull/44 this one for "how the thing will be actually dispatched"
#4650 is the equivalent for v2