Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add build to deployment composante + nightly flag #4655

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

louis-bompart
Copy link
Collaborator

@louis-bompart louis-bompart commented Nov 7, 2024

This PR adds a new kind of deployment: nightly deployments.
Quick-fire descriptions of Nightly Deployments:

They are only for the CDN
They are not for direct consumer uses (i.e. only Hosted Services may use them directly as "stop-gap" measure between official releases.
They are triggered manually
They only target a single "CDN path" per project & major (i.e. no v3.0-nightly, or v3.0.1-nightly, only v3-nightly
This PR concerns v3 deployment. Find the two related PR:

https://github.com/coveo-platform/ui-kit-cd/pull/44 this one for "how the thing will be actually dispatched"
#4650 is the equivalent for v2

Copy link

github-actions bot commented Nov 8, 2024

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 236.8 236.8 0
commerce 341.5 341.5 0
search 412.8 412.8 0
insight 402.1 402.1 0
recommendation 249.1 249.1 0
ssr 406.3 406.3 0
ssr-commerce 353.7 353.7 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@louis-bompart louis-bompart changed the title make build script nightly-ready chore: add build to deployment composante + nightly flag Nov 8, 2024
@louis-bompart louis-bompart marked this pull request as ready for review November 8, 2024 15:19
@louis-bompart louis-bompart requested a review from a team as a code owner November 8, 2024 15:19
Copy link
Contributor

@alexprudhomme alexprudhomme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So how would we trigger this ?

@alexprudhomme
Copy link
Contributor

So how would we trigger this ?

Is it a github action in ui-kit-cd ?

github-merge-queue bot pushed a commit that referenced this pull request Nov 11, 2024
This PR adds a new kind of deployment: nightly deployments.
Quick-fire descriptions of Nightly Deployments:
- They are only for the CDN
- They are not for direct consumer uses (i.e. only Hosted Services may
use them directly as "stop-gap" measure between official releases.
- They are triggered manually
- They only target a single "CDN path" per project & major (i.e. no
`v3.0-nightly`, or `v3.0.1-nightly`, only `v3-nightly`

This PR concerns v2 deployment. Find the two related PR:
- coveo-platform/ui-kit-cd#44 this one for "how
the thing will be actually dispatched"
- #4655 is the equivalent for
master.
@louis-bompart
Copy link
Collaborator Author

So how would we trigger this ?

Is it a github action in ui-kit-cd ?

Yes 👍
Will write brief docs once it works (testing with v2 for now)

@louis-bompart
Copy link
Collaborator Author

  • Add missing pieces that has been pushed into v2 branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants