refactor(headless, headless-react): no more generic engine in ssr-commerce types #4657
+74
−144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexprudhomme
force-pushed
the
ssr-commerce-no-engine-generic
branch
from
162dd59
to
5b20de5
Compare
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
alexprudhomme
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
alexprudhomme
requested review from
olamothe,
fpbrault,
y-lakhdar and
louis-bompart
alexprudhomme
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
alexprudhomme
force-pushed
the
ssr-commerce-no-engine-generic
branch
from
5b20de5
to
c1c2a13
Compare
alexprudhomme
had a problem deploying
to
PR Artifacts
GitHub Actions
Failure
alexprudhomme
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
louis-bompart
approved these changes
Nov 14, 2024
fbeaudoincoveo
approved these changes
Nov 15, 2024
| @@ -38,6 +38,9 @@ export default function ProductList() { | |||
| <button onClick={() => addToCart(cartMethods!, product)}> | |||
| Add to cart | |||
| </button> | |||
| <button onClick={() => addToCart(cartMethods!, product)}> | |||
There was a problem hiding this comment.
Why are there three add to cart buttons?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://coveord.atlassian.net/browse/KIT-3730
The original ssr solution was made to receive multiple engine. For the commerce use case, we had to duplicate a lot of the code since it was not prepared to receive a solutionType. In that duplication, we copied over the abstraction over the engine. It is not needed in ssr-commerce since every ssr-commerce implementation will always use the same engine which is SSRCommerceEngine.