Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Today I learned about Foundry's
sort_imports
fmt configuration option.As it has almost zero dev cost to use it, I'd go for it.
Drawback: I noticed a bug while formatting our code, specifically this section:
was changed to:
and I had to manually remove the extra newline.
I'd still say this isn't a big issue as we'd notice on reviewing.
Since I noticed it, I also removed a duplicate import.
Test Plan
CI doesn't fail on
fmt --check
.