Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate GPv2Settlement order refund tests to Foundry #196

Merged
merged 3 commits into from
Aug 7, 2024

Conversation

mfw78
Copy link
Contributor

@mfw78 mfw78 commented Aug 7, 2024

Description

See title. This is the last of the GPv2Settlement unit tests for migration. The GPv2SettlementTest contract isn't removed as the trade simulator still depends on this.

Test Plan

CI. See that all removed tests have been migrated.

Related Issues

Closes #119

@mfw78 mfw78 self-assigned this Aug 7, 2024
@mfw78 mfw78 requested a review from a team as a code owner August 7, 2024 11:53
Copy link
Contributor

@fedgiac fedgiac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Goodbye GPv2Settlement.test.ts.

test/GPv2Settlement/OrderRefunds.t.sol Outdated Show resolved Hide resolved
test/GPv2Settlement/OrderRefunds.t.sol Outdated Show resolved Hide resolved
mfw78 and others added 2 commits August 7, 2024 14:07
Co-authored-by: Federico Giacon <58218759+fedgiac@users.noreply.github.com>
@mfw78 mfw78 merged commit 5475208 into main Aug 7, 2024
9 checks passed
@mfw78 mfw78 deleted the unit-test-gpv2-settlement-part-7 branch August 7, 2024 14:15
@github-actions github-actions bot locked and limited conversation to collaborators Aug 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests(core): GPv2Settlement
2 participants