chore: migrate GPv2Trade extractOrder tests to Foundry #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfw78
approved these changes
Aug 8, 2024
test/GPv2Trade/ExtractOrder.t.sol
Outdated
Comment on lines
46
to
57
| assertEq(address(lhs.sellToken), address(rhs.sellToken)); | ||
| assertEq(address(lhs.buyToken), address(rhs.buyToken)); | ||
| assertEq(lhs.receiver, rhs.receiver); | ||
| assertEq(lhs.sellAmount, rhs.sellAmount); | ||
| assertEq(lhs.buyAmount, rhs.buyAmount); | ||
| assertEq(lhs.validTo, rhs.validTo); | ||
| assertEq(lhs.appData, rhs.appData); | ||
| assertEq(lhs.feeAmount, rhs.feeAmount); | ||
| assertEq(lhs.kind, rhs.kind); | ||
| assertEq(lhs.partiallyFillable, rhs.partiallyFillable); | ||
| assertEq(lhs.sellTokenBalance, rhs.sellTokenBalance); | ||
| assertEq(lhs.buyTokenBalance, rhs.buyTokenBalance); |
There was a problem hiding this comment.
Can we not simply do assertEq(keccak256(abi.encode(lhs)), keccak256(abi.encode(rhs))) ?
There was a problem hiding this comment.
Right! Fixed, 16 lines less. 🙂
mfw78
approved these changes
Aug 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See title.
Instead of just copying the order from a previous test and create all functions to fill its bytes, I decided a fuzz test is more appropriate to match the spirit of the previous test.
Test Plan
CI.
Related Issues
#121