chore: migrate GPv2Signing calldata manipulation tests to Foundry #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-signing-set-pre-signature
Co-authored-by: mfw78 <53399572+mfw78@users.noreply.github.com>
fedgiac
force-pushed
the
migrate-test-signing-calldata-manipulation
branch
from
70df7eb to
483e8f2
Compare
mfw78
approved these changes
Aug 15, 2024
…rate-test-signing-calldata-manipulation
mfw78
approved these changes
Aug 15, 2024
Base automatically changed from
migrate-test-signing-recover-order-from-trade
to
main
August 15, 2024 13:48
…rate-test-signing-calldata-manipulation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is only one test involved, and the logic of it has changed in the upgrade process.
The key difference is that we use Solidity version 0.8 in the tests, while the previous test used Solidity 0.7. The relevant part here is that contract calls now validate the padding in the calldata, making it impossible to successfully call
recoverOrderFromTradewith manipulated calldata. Curiously, this should have been the case since Solidity ~0.5, however it wasn't properly enforced until Solidity 0.8 (see ethereum/solidity repo here and discussion in the PR where this was introduced).Test Plan
CI.
Related Issues
#120