Update query to use hardcoded values for colocated solvers #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
harisang
reviewed
Sep 6, 2024
bram-vdberg
force-pushed
the
12-add-hardcoded-colocated-solver-addresses-for-cow-bonding-pool
branch
from
c5ed515 to
bed1344
Compare
9 tasks
harisang
force-pushed
the
12-add-hardcoded-colocated-solver-addresses-for-cow-bonding-pool
branch
from
5ebbb6a to
9991610
Compare
|
I took the liberty to add an alternative query that is simpler, at least to me, to parse. It is definitely doing redundant things and recomputing things here and there, but i had a bit of a hard time parsing the original query, so this is why i decided to do this. I am not suggesting we should use the new one, but would be good to have a look at both, proof-read them and then make a call |
|
One thing that needs to happen is that the original query should better invoke query 1541516 as black box, even if that means repeating some calculations. @bram-vdberg would be good to check how much this would simplify your query |
…for-cow-bonding-pool
|
Merging now as we need to execute the payouts tomorrow. Will open an issue to simplify the query |
harisang
deleted the
12-add-hardcoded-colocated-solver-addresses-for-cow-bonding-pool
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #12 and updates the CIP-48 query to use hard-coded values for colocated drivers.
This change also updates the logic for calculating the 3 month grace period for colocated solvers. Now, the logic only sets the grace period if they are manually marked as being in a reduced bonding pool.
Currently hardcoding all colocated solvers. Updates have been made to the CMS to allow us to get this information in a GitHub action, but since that's not live yet I'm adding these manually.