Skip to content
This repository has been archived by the owner on Dec 20, 2024. It is now read-only.

Split prefect deployments into dev and prod #124

Closed
wants to merge 7 commits into from
Closed

Conversation

bram-vdberg
Copy link
Collaborator

No description provided.

@bram-vdberg bram-vdberg marked this pull request as ready for review November 4, 2024 06:20
@harisang
Copy link
Contributor

harisang commented Nov 4, 2024

Should we rename some files? I see names such as dev_deployment that seem to only be about order rewards. Or is it that we will add each new jobs to all these files?

Copy link
Contributor

@fleupold fleupold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find the use of prefect in this public repository very weird. Imo prefect is part of our infrastructure so all logic around which workflows to run and how often should be configured in the infra repo. Dune-sync can trigger a build or release which can then cause some pipeline in the infra repo to run, but I don't think we should add all this stuff here.

Are we also planning to add a bunch of prefect code to token imbalances and the other data scripts that we need to run periodically?

@bram-vdberg
Copy link
Collaborator Author

Closing to move Prefect configs to a separate repository.

@bram-vdberg bram-vdberg closed this Nov 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants