This repository has been archived by the owner on Dec 20, 2024. It is now read-only.
Remove auction_transaction table from queries #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunce86
previously requested changes
Jan 31, 2024
src/sql/orderbook/batch_rewards.sql
Outdated
| @@ -57,8 +53,6 @@ order_surplus AS ( | |||
| THEN o.sell_token | |||
| END AS surplus_token | |||
| FROM settlements s -- links block_number and log_index to tx_from and tx_nonce | |||
There was a problem hiding this comment.
nit: update comment, tx_from and tx_nonce are not relevant anymore (for anything)
MartinquaXD
approved these changes
Feb 1, 2024
fleupold
dismissed
sunce86’s stale review
on holidays, so unable to re-review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adapts the relevant sql queries that were using the
auction_transactiontable to recover the auction_id, as the table is now deprecated.