This repository was archived by the owner on Dec 20, 2024. It is now read-only.
Implement CIP-36 #80
Merged
Implement CIP-36 #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No other change is necessary for CIP-36 since the rest of the reward logic is implemented on dune.
|
I updated the integration test for batch and order rewards to a block range from today.This block range includes an order with protocol fees and capped settlements from above and below, The separate test for protocol fees was removed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements changes due to CIP-36. See cowprotocol/solver-rewards#339 for more details.
Fewer changes are required in this repository compared to the solver-rewards repo since some of the reward logic is implemented on dune. The respective dune queries have to be adapted as well.
After merging this a resync for the accounting period starting on 06.02.2024 is required.