Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle more exceptions in web3 #116

Merged
merged 2 commits into from
Aug 23, 2024
Merged

Handle more exceptions in web3 #116

merged 2 commits into from
Aug 23, 2024

Conversation

fhenneke
Copy link
Contributor

This PR adds handling for general exceptions in some web3 functions.

There are crashes of the EBBO pod related to fetching data using web3py. The proposed change would handle those errors more gracefully and also show which errors are raised so they can be handled more explicitly.

mostly for debugging new errors
@fhenneke fhenneke requested a review from bram-vdberg August 23, 2024 07:54
Copy link

@bram-vdberg bram-vdberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fhenneke fhenneke merged commit ceb39e7 into main Aug 23, 2024
4 checks passed
@fhenneke fhenneke deleted the handle_more_exceptions branch August 23, 2024 09:30
@github-actions github-actions bot locked and limited conversation to collaborators Aug 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants