-
Notifications
You must be signed in to change notification settings - Fork 1
Add Mev Blocker kickbacks alert #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
bc80ef7
remove spaces
harisang 1e25137
add mev blocker kickbacks test
harisang 048de15
fix variable name
harisang 5eca982
fix alert bug
harisang 6c11247
correct phrasing and typo
harisang fd29ca1
Update src/monitoring_tests/mev_blocker_kickbacks_test.py
harisang dc6f0ee
rename variable throughout
harisang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
""" | ||
Checks whether there were any kickbacks received after each settlement. | ||
It generates an alert when kickbacks due to a specific settlement are | ||
more than KICKBACKS_ALERT_THRESHOLD | ||
""" | ||
# pylint: disable=logging-fstring-interpolation | ||
from src.monitoring_tests.base_test import BaseTest | ||
from src.apis.web3api import Web3API | ||
from src.constants import ( | ||
MEV_BLOCKER_KICKBACKS_ADDRESS, | ||
KICKBACKS_ALERT_THRESHOLD, | ||
) | ||
|
||
|
||
class MEVBlockerRefundsMonitoringTest(BaseTest): | ||
""" | ||
This test checks whether there was any MEV Blocker kicback, and | ||
generates a log/alert if this is the case. | ||
""" | ||
|
||
def __init__(self) -> None: | ||
super().__init__() | ||
self.web3_api = Web3API() | ||
|
||
def run(self, tx_hash: str) -> bool: | ||
""" | ||
Wrapper function for the whole test. Checks if kickback is more than | ||
KICKBACK_ETH_THRESHOLD, in which case it generates an alert. | ||
""" | ||
block_number = self.web3_api.get_tx_block_number(tx_hash) | ||
if block_number is None: | ||
return False | ||
|
||
total_eth_kickbacks = self.web3_api.get_eth_transfers_by_block_range( | ||
block_number, block_number, MEV_BLOCKER_KICKBACKS_ADDRESS | ||
) | ||
if total_eth_kickbacks is None: | ||
return False | ||
log_output = "\t".join( | ||
[ | ||
"MEV Blocker kickbacks test:", | ||
f"Tx Hash: {tx_hash}", | ||
f"Kickback: {total_eth_kickbacks:.5f}ETH", | ||
] | ||
) | ||
if total_eth_kickbacks >= KICKBACKS_ALERT_THRESHOLD: | ||
self.alert(log_output) | ||
else: | ||
self.logger.info(log_output) | ||
return True |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.