Remove quote test #92
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove fee test - remove test of fee test - remove quoting endpoint from orderbook api
harisang
approved these changes
Jan 12, 2024
harisang
force-pushed
the
remove_quote_test
branch
from
de4f435 to
671deb8
Compare
|
Not needed anymore due to PR #93 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The quote test was originally introduced to compare fees set by solvers to fees computed when creating quotes.
The test has proven unreliable and buggy. It is thus removed in this PR.
This also removes the quoting functionality in the orderbook api since it is not used anymore and probably will not be used in the future.