Fix query id for slippage accounting #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change to the query in #322 did noch change the dune query called from the code. Together with this change, a dune query was created using the cowprotocol account. The code was changed to point to that query.
bh2smith
approved these changes
Oct 10, 2023
harisang
approved these changes
Oct 11, 2023
|
Checked that local results are consistent with the already corrected Dune dashboard. So I will merge the change now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change to the
period_slippage.sqlquery in #322 did not change the dune query called from the code. This resulted in wrong slippage computations from this repository. The Dune dashboards already showed the correct slippage.In this PR, the code in
queries.pyis changed to point to a new Dune query created by cowprotocol. The code of that query is identical toperiod_slippage.sql.