Add runtime argument for minimum cow transfer threshold #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
bh2smith
approved these changes
Oct 25, 2023
fhenneke
reviewed
Oct 25, 2023
src/fetch/transfer_file.py
Outdated
| if tr.amount_wei > args.min_transfer_amount_wei: | ||
| payout_transfers.append(tr) | ||
| else: | ||
| if tr.amount_wei > args.min_transfer_amount_cow_atoms: |
There was a problem hiding this comment.
This reads a bit strange in that it does not refer to wei but is called amount_wei.
But renaming to amount or amount_atoms looks a bit overkill for the change in this PR.
fhenneke
approved these changes
Oct 25, 2023
fhenneke
approved these changes
Oct 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the option to specify a minimum COW transfer amount, effectively ignoring all transfers below that amount.
After merging this PR and before tagging a new release, I will do a PR in the infrastructure repo to set up these arguments correctly.